Franscobec/gddr6
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #23 from marcingomulkiewicz/feature/safer-mmap-params

Browse Source 
Safety: mmap changed to PROT_READ, open to O_RDONLY.
This commit is contained in:
Ole Algoritme
2024-03-24 09:40:36 +01:00
committed by GitHub
parent 67437ec951 334d6b71aa
commit 372666ec8c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gddr6.c
View File

@@ -163,7 +163,7 @@ int main(int argc, char **argv)
device->arch, device->dev_id, device->bus, device->dev, device->func); device->arch, device->dev_id, device->bus, device->dev, device->func);
} }
if ((fd = open(MEM, O_RDWR | O_SYNC)) == -1) if ((fd = open(MEM, O_RDONLY)) == -1)
{ {
printf("Can't read memory. If you are root, enable kernel parameter iomem=relaxed\n"); printf("Can't read memory. If you are root, enable kernel parameter iomem=relaxed\n");
PRINT_ERROR(); PRINT_ERROR();
@@ -180,7 +180,7 @@ int main(int argc, char **argv)
phys_addr = (device->bar0 + device->offset); phys_addr = (device->bar0 + device->offset);
base_offset = phys_addr & ~(PG_SZ-1); base_offset = phys_addr & ~(PG_SZ-1);
map_base = mmap(0, PG_SZ, PROT_READ | PROT_WRITE, MAP_SHARED, fd, base_offset); map_base = mmap(0, PG_SZ, PROT_READ, MAP_SHARED, fd, base_offset);
if(map_base == (void *) -1) if(map_base == (void *) -1)
{ {